bugs

Forum > Bugs > Editing clan profile: empty fields
Reply To Thread (login)
Jans [85]
2011-09-24 13:06:06
[13 years, 93 days ago]

This is what i see when i go to the clan settings page:

http://i.imgur.com/9LUMf.png

Shouldn't be, right? Our clan does have a profile and pic. I'm using Chrome 14.


 
Ender [1]
Administrator
2011-09-24 13:12:08
[13 years, 93 days ago]

Whoops, fixed.


 
Jans [85]
2011-09-24 13:13:21
[13 years, 93 days ago]

yayz0r


 
Jans [85]
2011-09-24 13:14:10
[13 years, 93 days ago]

Problem solved In 6 minutes, nice response time :P


 
Ender [1]
Administrator
2011-09-24 13:19:05
[13 years, 93 days ago]

Pro of not having a real build cycle: You can identify and fix a bug in 6 minutes.

Con of not having a real build cycle: You can break things even faster and leave them live longer.

This has been broken since I made the clan profile update last night. There's this bit of code that gets run on every page if you're logged in that initializes your bot info with stuff that appears on every page. This is basically what's included in the HUD - your name, level, clan, wins, losses, etc. I noticed while doing the clan profile update that this was also retrieving the clan image, profile, and MOTD. That was surely wrong, so I deleted it...which would have been fine, except that the clan settings page was expecting that data to already be populated. Now it gets it itself. :)


 
Ender [1]
Administrator
2011-09-24 13:22:40
[13 years, 93 days ago]

Fun fact: I also broke the clan rankings and clan profile page with the bot profile update and didn't notice for a good 10 minutes. We're talking server error 500 - nothing loaded at all. I added a "profile" field to the bots table, but this didn't play nice with the unqualified references to the "profile" field in the clans table.

I've written exactly one unit test for this entire game and it tests something completely useless. My users are my unit tests, you guys will tell me when I break something...I'm really a hack.


 
Ender [1]
Administrator
2011-09-24 13:25:04
[13 years, 93 days ago]

Oh this is actually kind of funny. I actually do have some sort-of-useful tests that I run before every update, but these detect things like trailing whitespace and tabs insteads of spaces. Solid priorities.

Also, triple post ftw.


 
Jans [85]
2011-09-24 13:34:19
[13 years, 93 days ago]

Tssk... pick a database naming convention and stick to it :P


 
DarkNinjaMaster [84]
2011-09-24 14:09:13
[13 years, 93 days ago]

My users are my unit tests

Ah, I wondered what we were here for.


 
Mithrandon [123]
2011-09-24 16:24:06
[13 years, 93 days ago]

just make a unit test every time you fix a bug, problem solved.


 
Ender [1]
Administrator
2011-09-24 16:52:31
[13 years, 93 days ago]

That's ideally how I would do it (and also write unit tests for new features in the first place), but that would require me to not be a hack.


 
Draoi [137]
2011-09-25 18:54:48
[13 years, 92 days ago]

I find it fun to try to find bugs.


 
Forum > Bugs > Editing clan profile: empty fields
Reply To Thread (login)