bugs

I complained about this to Ender (uncertain about how long ago it was) that the order of the buffs on our buff bar did not match the order of them on the trophy page (and yes the visual issue was more than just an eye sore).

He had fixed them so both of them were in the same order (occasionally helps when buying them so you didn't have to think too much and accidentally buy the wrong one). Also, the "gold" buffs were all at the beginning of the buff bar grouped together (not how they are now where they're located placed when he added them)

I noted in his announcement thread that when he added Global Buffs, it reverted the buff bar order back to the old one. Hoping creating a new thread will shed more light on the issue and get it fixed. (And to get other's inputs on whether they prefer the chaos or would prefer more order).

Thanks for the report, this should be fixed now.

For reference, the expected buff bar ordering is:

• Global buffs before regular buffs.
• Non-purchasable buffs before regular buffs.
• For purchasable buffs, use trophy page shop order.
• For non-purchasable buffs, use a deterministic order.

(Technical details/history belowing this point for anyone interesting, feel free to ignore if not.)

On 2024-11-07, I made the buff bar match the trophy page shop order (https://bots4.net/forum/4/8009#101025). Things working as intended starting at this point.

On 2024-12-23, I broke this when adding global buffs (https://bots4.net/forum/10/8047#101819). Things no longer working as intended starting at this point.

The query for obtaining a player's buffs changed from something like:

SELECT ... (regular buffs) ... ORDER BY sort_order

To something like

(SELECT ... (global buffs) ... ORDER BY sort_order)
UNION ALL
(SELECT ... (regular buffs) ... ORDER BY sort_order)

Apparently, the output order of this new form is undefined (in practice, it was likely using the physical ordering which is based on buff id, i.e. the order that buffs were introduced into the game). The fix was to lift the ORDER BY outside of the UNION ALL:

(SELECT 1 AS source_query, sort_order, ... (global buffs) ...)
UNION ALL
(SELECT 2 AS source_query, sort_order, ... (regular buffs) ...)
ORDER BY source_query, sort_order

Thanks Ender. I really do appreciate you taking the time to solve this mostly likely very easy and simple thing, and taking away tome from more important things.

Want to point out that I'm not being sarcastic and/or condescending. I really do appreciate the fact that you not only revived this game but continue to take feedback, attempt to push things forward while also maintaining the simplicity of the game that made so many of us fall into the trap of playing it.