Can we have it so clicking the buff icon itself toggles it on and off?
suggestions
|
|
Fishwick [135] Moderator |
|
|
What about the cancel button? I did use it once on purpose! |
|
We can have a click toggle without getting rid of the pop-up thing |
<Apex>
|
Not on phone, although maybe it could be an option in settig to turn on/off. |
Administrator |
This is done, but please be on the lookout for bugs. The desktop behavior now is:
And the mobile behavior now is:
The split behavior based on desktop/mobile was challenging to implement and had quite a few edge cases. I've tested fairly thoroughly, but as stated at the top, please be on the lookout for bugs. I also reserve the right to walk this feature back if it turns out to be confusing or undesirable for whatever reason. In particular, the long hold functionality on mobile doesn't feel very discoverable, so I'm a little worried about that. We'll see how it goes. |
Endex [95] <Valhalla>
|
Based on current behavior. I have to click and hold for the popup on desktop. |
Administrator |
It sounds like it's not properly detecting that you have a mouse capable of hovering. What kind of device are you playing on? Also, if you know how to do this, can you put both of these lines (separately) into the JS console of your device and tell me what it says? window.matchMedia('(hover: hover)').matches window.matchMedia('(pointer: fine)').matches |
Endex [95] <Valhalla>
|
I'm currently on a windows "tablet" (ASUS ROG Flow Z13) with a razer dock and Black Widows v3 keyboard and Razer Basalisk Mouse. |
Endex [95] <Valhalla>
|
Both of those return "false". |
Endex [95] <Valhalla>
|
Could it being a touchscreen cause concern? (Side note I have no issue with it being the way it is for me currently) |
<Apex>
|
Much better on desktop, on phone it's weird though you can open multiple and can't close them again without tapping another. |
Bazza [385] |
And my current experience is mixed. I have to hold to get the popup, but opening a 2nd makes the 1st disappear (likely what is intended on mobile). |
Administrator |
Thanks everyone for the testing and quick feedback. @Endex - The touchscreen capability of your device is indeed what's confusing the code. Glad to hear the current behavior is working okay for you though, that's helpful to know. I'll probably leave this part untouched unless more related feedback comes in. @Zach and @Bazza - Oops, thanks for testing multiple buff use cases. I actually foolishly didn't think to test those. It also sounds like the behavior with this is potentially inconsistent (Zach seeing multiple popups stay open, Bazza seeing the new one close the old one). Stay tuned - I'll play around with the multi-buff interactions and probably update the code. In the meantime, let me know if anyone else experiences anything odd for single buff use cases. |
Endex [95] <Valhalla>
|
Sorry for the confusion Ender, Bazza = me also. |
Endex [95] <Valhalla>
|
Just tested on my phone though, and I'm experiencing the same thing Zach described. |
Administrator |
I just pushed out a fix that prevents multiple buff details popups from being open at the same time. With that, this feature should now be working as expected, besides devices like gaming tablets not properly being detected as capable of hovering. If more reports of issues with this come in, I'll investigate further (especially since if you don't know about long press, then you have no way to get buff details). Let me know if anyone spots any other issues! |