bugs

Mithrandon [163]
2013-03-26 12:12:43
[11 years, 274 days ago]

i was just corresponding with a fellow Dane when i noticed that all our special characters including tailing letters/spaces was missing from the texts.

is this a character set issue? i tried to change it but the letters is still missing so i guess it didn't make it to the database in the first place

i'm using chrome btw


 
Jans [87]
2013-03-26 16:40:38
[11 years, 273 days ago]

yea, character set of the game doesnt support too many characters.


 
Ender [1]
Administrator
2013-03-26 20:12:14
[11 years, 273 days ago]

Yep, non-English languages are pretty much broken on bmails and forum posts. I think I know what I need to do to fix this and if I'm right, it shouldn't be hard. Can someone post some non-English sentences in this thread I can test with?


 
Samuli [73]
2013-03-26 20:21:29
[11 years, 273 days ago]

Mörkö syö kaikilta pään. åæéø


 
KiNG ERiC [150]
2013-03-26 20:22:24
[11 years, 273 days ago]

Flagboy


 
Ender [1]
Administrator
2013-03-26 20:33:15
[11 years, 273 days ago]

And for extra points, please post a screenshot from another website or word processor or whatever of what the text should look like.


 
Samuli [73]
2013-03-26 20:40:28
[11 years, 273 days ago]

http://i.imgur.com/7Y46Cqy.png


 
ArmyOfCocks [57]
2013-03-26 20:42:05
[11 years, 273 days ago]

私はあなたが大好きエンダー

http://i.imgur.com/fiTQG0X.png


 
Ender [1]
Administrator
2013-03-26 22:02:14
[11 years, 273 days ago]

Good news. I changed the encoding from ISO-8859-1 to UTF-8 and that seems to have fixed some things. The issue was not with how the text was being stored, but rather how it was presented, so this should fix the rendering of existing posts/bmails too.

For the posts in this thread:

  • Samuli - What language is that? It doesn't look anything like the screenshot you posted. :\ (nor did it change at all after changing the encoding)
  • KiNG ERiC - What?
  • ArmyOfCocks - The Japanese now renders correctly, w00t.

I also spot checked some of the posts in http://bots4.net/forum/8/2206 (Croatian thread) and they look good now too. If Samuli's issue is resolved, we should be good to go.

Mith, check your bmail again and let us know here how it looks now?


 
Jans [87]
2013-03-26 22:59:20
[11 years, 273 days ago]

�? Touché?


 
Jans [87]
2013-03-26 23:00:58
[11 years, 273 days ago]

http://i.imgur.com/87OVnKk.png


 
Ender [1]
Administrator
2013-03-26 23:10:15
[11 years, 273 days ago]

Since it works in the preview, but not the actual post, that suggests there actually is a problem with the way it's being stored too. That part will probably be harder to fix, but let's see...


 
Ender [1]
Administrator
2013-03-27 00:07:25
[11 years, 273 days ago]

�? Touché!

All right, give it another try. PHP wasn't encoding things properly when escaping user input, but it is now. This unfortunately means most existing non-English posts will continue to render incorrectly because they were saved like that, but things should be fixed going forward.


 
Ender [1]
Administrator
2013-03-27 00:08:36
[11 years, 273 days ago]

Oops, false alarm, code update failed. One sec...


 
Ender [1]
Administrator
2013-03-27 00:36:04
[11 years, 273 days ago]

€? Touché! Okay, try now. :)


 
Jans [87]
2013-03-27 02:31:48
[11 years, 273 days ago]

Yay!

Nyt voimme ymmärtää suomea!


 
Esvrainzas [134]
2013-03-27 11:05:57
[11 years, 273 days ago]

I'll try portuguese.

Escapism é o melhor clan em que estive. É uma sensação ótpima! Agora todos os caracteres especiais que me lembro: é, à, á, ó, í, ú, ñ, ç, ê, ã, õ...


 
Esvrainzas [134]
2013-03-27 11:06:54
[11 years, 273 days ago]

It works! and I wrote wrong one word -.-

óptima is the correct word.


 
hayabassie [147]
2013-03-27 11:33:04
[11 years, 273 days ago]

En Nederlands dan? ken hij ook Nederlands


 
Esvrainzas [134]
2013-03-27 11:34:10
[11 years, 273 days ago]

Isso não tem caracteres especiais haybassie...


 
Sangu [128]
2013-03-27 11:44:50
[11 years, 273 days ago]

Lietuvių kalba irgi veikia? PanaÅ¡u, kad taip. Ä… Ä Ä™ Ä— į Å¡ ų Å« ž


 
Leader [92]
2013-03-27 11:45:55
[11 years, 273 days ago]

i don't like this what are you all saying i can only speak one language :(


 
hayabassie [147]
2013-03-27 11:49:25
[11 years, 273 days ago]
i don't like this what are you all saying i can only speak one language :(

Hmm, it's not English. So which one is it?


 
Leader [92]
2013-03-27 11:50:29
[11 years, 273 days ago]

gibberish?


 
dragonrose [54]
Head Moderator
2013-03-27 14:18:03
[11 years, 272 days ago]

great, can't wait for the croatian thread to appear ....


 
ActiveX [172]
Head Moderator
2013-03-27 14:49:28
[11 years, 272 days ago]

£ £ £ £ £ £ £ £ £ £

yay no more GB pound :)


 
Mithrandon [163]
2013-03-27 15:52:24
[11 years, 272 days ago]

as you found out the bmail was saved with errors so they are still missing the special chars.

testing: æ ø å


 
Mithrandon [163]
2013-03-27 15:54:35
[11 years, 272 days ago]

but the new mails i send works so all good to go


 
Ender [1]
Administrator
2013-03-27 17:37:45
[11 years, 272 days ago]

Awesome, glad this works now! Thanks for all the testing help everyone. I'll make an announcement about this so everyone knows they can use non-English characters now.


 
shoyuken [174]
2013-03-29 15:48:30
[11 years, 270 days ago]

Interesting... I just noticed I lost my battlecry. I'm guessing it has to do with these changes?


 
shoyuken [174]
2013-03-29 16:09:44
[11 years, 270 days ago]

Hm... i've checked a few bots with yeller trophies and they don't have battlecries. A few bots like Nigel and Draoi still seem to have them though. Thognix just got the yeller trophy 4 days ago, but has no battle cry.... Anyone else experience anything like this?


 
Myriad [340]
2013-03-30 00:15:46
[11 years, 270 days ago]

You can add battle cries just to get the trophy, then remove them once you have it


 
shoyuken [174]
2013-03-30 06:55:46
[11 years, 270 days ago]

Yeah I figured that, but my battle cry disappeared and I don't share this bot. I may have had some special characters in it before and it got wiped when Ender implemented this change? Which is why I specified that Draoi and Nigel still had their battlecries, cause they would be less likely to put in some strange characters into their battlecry as compared to some other bots from different countries.


 
shoyuken [174]
2013-03-30 07:05:08
[11 years, 270 days ago]

From memory, I think my battle cry used to be something like this

(      '.')~c (#) Here's a strudel

But when I tried putting that into my battlecry (after I realized it was missing) It can only display as this during fights:

 ( '.')~c (#) Here's a strudel 

 
shoyuken [174]
2013-03-30 07:09:43
[11 years, 270 days ago]

It would be hard for most people to notice this (if this is an actual bug) unless they are fighting their main or ratio whore or dumper and that particular bot has a battlecry


 
Ender [1]
Administrator
2013-03-30 11:43:44
[11 years, 270 days ago]

This shouldn't have affected battle cries. I'll take a look.


 
Ender [1]
Administrator
2013-04-01 21:59:31
[11 years, 267 days ago]

I'm thinking you're mistaken, shoyuken. This update didn't touch any of the underlying data stored for forum posts, bmails, battle cries, etc.

To further confirm, I checked the 3/28 backup (taken 12:05am ET) and found your original battle cry was present.

The issue with the repeated spaces being collapsed to a single one doesn't look new (and probably not worth addressing). I tried rolling back the changes involved in making non-English characters work on the game and they still got collapsed to a single space.


 
Jans [87]
2013-04-01 22:32:15
[11 years, 267 days ago]

That's normal behavior though, multiple spaces are always compacted in html.

Instead you could try to use a bunch of:

 

 
Ender [1]
Administrator
2013-04-01 22:37:43
[11 years, 267 days ago]

Yeah, the question is whether the code that displays the battle cries should replace regular spaces with non-breakable spaces so that they don't get collapsed. I'd argue no, but I could be swayed if people really want this.


 
Mithrandon [163]
2013-04-05 06:57:14
[11 years, 264 days ago]

i think it would be better to just put it in the text formatting guide, along with some of the other commonly used entities for making white space


 
Ender [1]
Administrator
2013-04-05 08:39:45
[11 years, 264 days ago]

There's no special formatting allowed for battle cries. I suspect that most people don't care about whitespace in them, but if this were to be supported, it wouldn't require special formatting on the user's part, just a replacement of spaces with " " characters when outputting so that consecutive ones don't get collapsed.

I'd recommend opening a suggestions thread if anyone really wants to see this feature added since the bug this thread is about, non-English characters, is fixed. :)